rely on patched datasets home rather than passing it around #5998
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmeier
commented
May 12, 2022
| @@ -25,9 +25,10 @@ def extract_datapipes(dp): | |||
| return get_all_graph_pipes(traverse(dp, only_datapipe=True)) | |||
|
|
|||
|
|
|||
| @pytest.fixture | |||
| @pytest.fixture(autouse=True) | |||
There was a problem hiding this comment.
Although this patch is now applied by default, if required, a test can still request this fixture the normal way.
facebook-github-bot
pushed a commit
that referenced
this pull request
May 24, 2022
…5998) Summary: * rely on patched datasets home rather than passing it around * add comment Reviewed By: datumbox Differential Revision: D36413359 fbshipit-source-id: cccff560e6e29da8401fab866a34ebe0fdde6b9a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #5990, I realized we don't need to pass the
test_hometo our mock data generation, since we later already rely on the patched version. With this PR, the preparation as well as the loading now rely on the patched home.Note that this does not conflict with anything in #5990.