Skip to content

Merge mock data preparation and dataset logic in prototype tests #6010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 17, 2022

Conversation

pmeier
Copy link
Collaborator

@pmeier pmeier commented May 13, 2022

This was extracted out of #5990.

Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pmeier , I made some comment below

@pmeier pmeier requested a review from NicolasHug May 16, 2022 12:15
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Philip, last comment but LGTM regardless

@pmeier pmeier merged commit 08c8f0e into pytorch:main May 17, 2022
@pmeier pmeier deleted the mock-data-loading branch May 17, 2022 11:21
facebook-github-bot pushed a commit that referenced this pull request Jun 1, 2022
…ests (#6010)

Summary:
* merge mock data preparation and loading

* address comments

* fix extra file creation

* remove tmp folder

* inline images meta creation in coco mock data

Reviewed By: NicolasHug

Differential Revision: D36760945

fbshipit-source-id: 946485ad56d69c88a3a9e95b1b2402b3356a894c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants