Skip to content

Add more info on new models.srt #6025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
May 16, 2022
Merged

Add more info on new models.srt #6025

merged 13 commits into from
May 16, 2022

Conversation

datumbox
Copy link
Contributor

@datumbox datumbox commented May 16, 2022 •
edited
Loading

Addresses partially #6014

Demo: https://output.circle-artifacts.com/output/job/a9a5210b-ed03-4165-9e8f-24a5071eeb82/artifacts/0/docs/models_new.html

This PR:

  • Transfers all the missing information from the old docs (Torch Hub, validation dataset info) and adds references to galleries when available
  • Adds additional new info for models (licensing, code examples for meta-data, preprocessing usage)
  • Performs small updates on the code examples and docs.
  • Makes partially visible the category meta. See screenshots below:

image

image

@datumbox datumbox requested a review from NicolasHug May 16, 2022 13:44
@datumbox datumbox removed the request for review from NicolasHug May 16, 2022 13:44
@datumbox datumbox marked this pull request as draft May 16, 2022 13:44
@datumbox datumbox mentioned this pull request May 16, 2022
Closed
6 tasks
@datumbox datumbox changed the title [WIP] Add more info on new models.srt Add more info on new models.srt May 16, 2022
@datumbox datumbox requested a review from NicolasHug May 16, 2022 15:56
@datumbox datumbox marked this pull request as ready for review May 16, 2022 15:56
NicolasHug
NicolasHug approved these changes May 16, 2022
View reviewed changes
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @datumbox , minor comment but LGTM!

@datumbox datumbox merged commit 769ae13 into pytorch:main May 16, 2022
@datumbox datumbox deleted the docs/models_additional_info branch May 16, 2022 16:38
@datumbox datumbox linked an issue May 16, 2022 that may be closed by this pull request
Improve documentation for Multi-weight support #6014
Closed
6 tasks
facebook-github-bot pushed a commit that referenced this pull request Jun 1, 2022
@YosuaMichael @NicolasHug @facebook-github-bot
[fbsync] Add more info on new models.srt (#6025)
152db39 
Summary:
* Minor updates on model examples.

* Improving wording of auto-generated docs.

* Add general info for pre-trained weights.

* Updating torch hub

* Minor updates

* Make lengthy meta-data partially visible

* Adding meta-data and reference info.

* Minor corrections

* Update docs/source/models_new.rst

* Moving Torch hub section at the end

Reviewed By: NicolasHug

Differential Revision: D36760948

fbshipit-source-id: 19c1d120ca0e9c0dbaf672f9f7fa2a60d4493533

Co-authored-by: Nicolas Hug <[email protected]>
Co-authored-by: Nicolas Hug <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oke-aditya oke-aditya oke-aditya left review comments

@NicolasHug NicolasHug NicolasHug approved these changes

Assignees
No one assigned
Labels
cla signed enhancement module: documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve documentation for Multi-weight support
4 participants
@datumbox @NicolasHug @oke-aditya @facebook-github-bot