Update galleries to use Multi-weight idioms #6030
Conversation
datumbox
changed the title
|
|
||
| grid = make_grid([dog1_int, dog2_int, dog1_int, dog2_int]) | ||
| grid = make_grid(dog_list) |
There was a problem hiding this comment.
Not sure why we were showing twice the picture of each dog previously.
There was a problem hiding this comment.
I'd be in favour of removing this section about make_grid entirely. We shouldn't encourage our users to use it anymore, there are much better alternatives
There was a problem hiding this comment.
Sounds good to me, let's do this on a separate PR to explore what the better recommended alternative is. cc @oke-aditya
|
|
||
| grid = make_grid([dog1_int, dog2_int, dog1_int, dog2_int]) | ||
| grid = make_grid(dog_list) |
There was a problem hiding this comment.
I'd be in favour of removing this section about make_grid entirely. We shouldn't encourage our users to use it anymore, there are much better alternatives
gallery/plot_visualization_utils.py
Outdated
| ] | ||
|
|
||
| inst_class_to_idx = {cls: idx for (idx, cls) in enumerate(inst_classes)} | ||
| inst_class_to_idx = {cls: idx for (idx, cls) in enumerate(weights.meta["categories"])} |
There was a problem hiding this comment.
Good spot. Actually I don't know why this was here. We never printed it. I think I'll just remove it rather than printing a big mapping table on the docs.
Summary: * Update the preprocessing decription for RAFT. * Fixing incorrect usage of models. * Fixing the content of viz utils * Addressing review comments Reviewed By: NicolasHug Differential Revision: D36760941 fbshipit-source-id: 6e3bcf535a13799a34e4ca45ff7bdc64c2901c63
Resolves partially #6014
This PR: