New schema for metrics in weights meta-data #6047
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datumbox
reviewed
May 18, 2022
| "box_map": 50.6, | ||
| "kp_map": 61.1, | ||
| "_metrics": { | ||
| "COCO-val2017": { |
There was a problem hiding this comment.
Non blocking question. @fmassa Any thoughts on the name of keypoints dataset here?
datumbox
reviewed
May 18, 2022
datumbox
approved these changes
May 18, 2022
There was a problem hiding this comment.
We should be able to merge after fixing the nits. Stamping to unblock. Thanks for the work @NicolasHug.
|
CI is completely toasted (didn't even start some jobs) so I'll merge now. Everything was fine locally, hopefully this doesn't add any additional problems. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 1, 2022
Summary: * Classif models * Detection * Segmentation * quantization * Video * optical flow * tests * Fix docs * Fix Video dataset * Consistency for RAFT dataset names * use ImageNet-1K * Use COCO-val2017-VOC-labels for segmentation * formatting Reviewed By: NicolasHug Differential Revision: D36760921 fbshipit-source-id: 6efc259c6b8b922510a35be0ed1ca071e2a53a6f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5973
This PR: