Skip to content

Remove deprecation warning for pts on read_video #6056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Remove deprecation warning for pts on read_video #6056

wants to merge 2 commits into from

Conversation

datumbox
Copy link
Contributor

@datumbox datumbox commented May 20, 2022 •
edited
Loading

Addressing #6013 (comment)

I've opted to comment it out instead of removing it to leave some kind of notice about the potential issue of using pst. Happy to remove it.

@datumbox datumbox requested a review from bjuncek May 20, 2022 10:13
@datumbox datumbox mentioned this pull request May 20, 2022
Merged
@datumbox datumbox mentioned this pull request May 20, 2022
Merged
bjuncek
bjuncek approved these changes May 20, 2022
View reviewed changes
Copy link
Contributor

@bjuncek bjuncek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, LGTM

@datumbox
Copy link
Contributor Author

I think we should not merge this and instead finalize and merge #5952

@datumbox datumbox closed this May 20, 2022
@datumbox datumbox deleted the video/remove_deprecation branch May 20, 2022 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@bjuncek bjuncek bjuncek approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla signed code quality module: video
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@datumbox @bjuncek @facebook-github-bot