Skip to content

Adding _log_api_usage_once to Swin's reusable components #6174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 16, 2022

Conversation

datumbox
Copy link
Contributor

We forgot to add the logger on the reusable components of Swin Transformer. @YosuaMichael's refactoring at #6088 enabled us to reuse this implementation at facebookresearch/multimodal#43. The logger, which is no-op for any user outside Meta, will allow us to trace better internal usages at Meta and keep an eye on modifications we need to do in these components to make them reusable.

Copy link
Contributor

@YosuaMichael YosuaMichael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I didn't know about this before!
The changes looks good to me

@datumbox datumbox merged commit ac5dc51 into pytorch:main Jun 16, 2022
@datumbox datumbox deleted the swin/add_missed_logger branch June 16, 2022 12:51
NicolasHug added a commit to NicolasHug/vision that referenced this pull request Jun 16, 2022
…ytorch#6174)

Differential Revision: D37212662

fbshipit-source-id: 6ba28b0ffb588ee93972e76482833013a0e6f03b
facebook-github-bot pushed a commit that referenced this pull request Jun 17, 2022
…6174)

Reviewed By: datumbox

Differential Revision: D37212662

fbshipit-source-id: 051c69540c15723d3ce0780b8fcba5693cc9114a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants