[proto] Improvements for functional API and tests #6187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vfdev-5
force-pushed
the
update-proto-test-rotate-image
branch
from
4192565 to
88f1822
Compare
vfdev-5
force-pushed
the
update-proto-test-rotate-image
branch
from
88f1822 to
25b3667
Compare
vfdev-5
changed the title
datumbox
reviewed
Jun 23, 2022
datumbox
reviewed
Jun 23, 2022
Other nits
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 27, 2022
Summary: * Added base tests for rotate_image_tensor * Updated resize_image_tensor API and tests and fixed a bug with max_size * Refactored and modified private api for resize functional op * Fixed failures * More updates * Updated proto functional op: resize_image_* * Added max_size arg to resize_bounding_box and updated basic tests * Update functional.py * Reverted fill/center order for rotate Other nits Reviewed By: NicolasHug Differential Revision: D37450357 fbshipit-source-id: 5e81dc93190369af438235c8611eb0b375afd434
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
rotate_image_tensorresize_image_tensorAPI and tests and fixed a bug withmax_sizemax_sizearg toresize_bounding_boxand updated basic tests