Torch7 naming convention for ROIAlign C++ code #629
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmassa
reviewed
Oct 17, 2018
| @@ -116,8 +116,8 @@ std::tuple<at::Tensor, at::Tensor> ROIPool_forward_cuda(const at::Tensor& input, | |||
| auto height = input.size(2); | |||
| auto width = input.size(3); | |||
|
|
|||
| at::Tensor output = input.type().tensor({num_rois, channels, pooled_height, pooled_width}); | |||
| at::Tensor argmax = input.type().toScalarType(at::kInt).tensor({num_rois, channels, pooled_height, pooled_width}).zero_(); | |||
| at::Tensor output = at::zeros({num_rois, channels, pooled_height, pooled_width}, input.type()); | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
varunagrawal
force-pushed
the
roi-align
branch
from
320d0a3 to
8c0cdf7
Compare
|
@fmassa updated. |
|
@varunagrawal I believe #632 contains all the commits from this branch, right? So we can close this? |
|
@fmassa yup. I simply rebased the branches on top of each other. I assumed having separate PRs for each would make debugging in the future easy. |
rajveerb
pushed a commit
to rajveerb/vision
that referenced
this pull request
Nov 30, 2023
* Add MLCube implementation * Update MLCube readme * Update MLCube Readme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets the naming convention for input and output to be consistent with the Torch7 style.
Also abstracted out the
CUDA_1D_KERNEL_LOOPinto the helper class just like ROIPool.