replace query_recursively with pytree implementation #6434
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmeier
commented
Aug 17, 2022
vfdev-5
approved these changes
Aug 17, 2022
vfdev-5
reviewed
Aug 17, 2022
| @@ -361,7 +352,7 @@ def __init__( | |||
| def forward(self, *inputs: Any) -> Any: | |||
| sample = inputs if len(inputs) > 1 else inputs[0] | |||
|
|
|||
| id, image = self._extract_image(sample) | |||
| sample_flat, sample_spec, idx_flat, image = self._flatten(sample) | |||
There was a problem hiding this comment.
I appologize if I'm missing the context, If I understand correctly the code, you fetch the first image from sample with _flatten and below in the code the image is transformed and written back to sample.
Why do we transform only the first image ?
There was a problem hiding this comment.
More generally question, why can't we restructure the implementation such that we use forward to inspect sample and ensure that only images (and/or only one image in sample) go further into _transform. In _transform we do the necessary AA ops. What do you think ?
datumbox
reviewed
Aug 17, 2022
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 25, 2022
Summary: * replace query_recursively with pytree implementation * simplify Reviewed By: datumbox Differential Revision: D39013677 fbshipit-source-id: ac63607513bb5457ead65e798a8704c6341c5c50 Co-authored-by: vfdev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #6408 (comment).