-
Notifications
You must be signed in to change notification settings - Fork 7.1k
[proto] Use the proper _transformed_types
in all Transforms and eliminate unnecessary dispatching
#6494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
# Conflicts: # torchvision/prototype/transforms/_deprecated.py # torchvision/prototype/transforms/_type_conversion.py
_transformed_types
in all Transforms and eliminate unnecessary dispatching
_transformed_types
in all Transforms and eliminate unnecessary dispatching_transformed_types
in all Transforms and eliminate unnecessary dispatching
323aed2
to
79944f6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question. Otherwise LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@datumbox CI failures are related : https://github.com/pytorch/vision/runs/8015985956?check_suite_focus=true
|
@datumbox CI failures are still related to your latest commit:
You can check that locally: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @datumbox !
…s and eliminate unnecessary dispatching (#6494) Summary: * Update types in deprecated transforms. * Update types in type conversion transforms. * Fixing types in meta transforms. * More changes on type conversion. * Bug fix. * Fix types * Remove unnecessary conversions. * Remove unnecessary import. * Fixing tests * Remove copy support from `to_image_tensor` * restore test param * Fix further tests Reviewed By: NicolasHug Differential Revision: D39131008 fbshipit-source-id: f44bff9066888661a764fe0a50a77894d2c31140
Addresses some of the remarks at #6486
This PR:
_transformed_types
types to all transforms_transform()
_transform()