[vision_transformer] Make the assert message more verbose #6583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datumbox
approved these changes
Sep 14, 2022
|
This already pass linux unittest which I think is enough, the other error on the test is not related to the PR. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 15, 2022
Reviewed By: jdsgomes Differential Revision: D39543281 fbshipit-source-id: 1d17cf15f5c830be10befaf13158803dd105c5c3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small patch addressing problem mentioned in #6428
Currently we give error message like:
This is not clear to users on what the expected height should be. In this PR we make this more verbose and add the input height and expected height. Now it become: