Skip to content

[proto] Argument fill can accept dict of base types #6586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 15, 2022

Conversation

vfdev-5
Copy link
Collaborator

@vfdev-5 vfdev-5 commented Sep 15, 2022

No description provided.

Copy link
Contributor

@datumbox datumbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except only one remark before merging.

@datumbox datumbox mentioned this pull request Sep 15, 2022
@datumbox datumbox merged commit e0e9538 into pytorch:main Sep 15, 2022
@vfdev-5 vfdev-5 deleted the proto-fill-as-dict branch September 15, 2022 11:59
facebook-github-bot pushed a commit that referenced this pull request Sep 15, 2022
Summary: Co-authored-by: Vasilis Vryniotis <[email protected]>

Reviewed By: jdsgomes

Differential Revision: D39543288

fbshipit-source-id: 5763f1d98152303251ff3d3dd60eac0ebaeada2a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants