reduce verbosity of prototype tests and split them into multiple steps #6587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vfdev-5
approved these changes
Sep 15, 2022
YosuaMichael
approved these changes
Sep 15, 2022
There was a problem hiding this comment.
Thanks @pmeier , this looks good! hope it can help resolve truncated logs issue!
facebook-github-bot
pushed a commit
to pytorch/data
that referenced
this pull request
Sep 15, 2022
Summary: This PR is required since pytorch/vision#6587 has been landed and shipped to TorchVision nightly. Pull Request resolved: #774 Reviewed By: NivekT Differential Revision: D39542299 Pulled By: ejguan fbshipit-source-id: 5871263867a2f906b192677bde027c99e398bcdc
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 15, 2022
…iple steps (#6587) Summary: * reduce verbosity of prototype tests and split them into multiple steps * rename builtin datasets module to fit common scheme Reviewed By: jdsgomes Differential Revision: D39543283 fbshipit-source-id: d1eccfbf9aaef2e551259373619d7e4cb8a4d0c0
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running with
-vvvemits one line per test / parametrization, which leads to enormous logs with very little information. They take some time to load and in some instances GH even truncates the log. That means one needs to take extra steps just to see the failing test.This PR reduces the verbosity to a normal level. Now tests will only be shown as a single character, i.e.
.for passing orFfor failing, while the total percentage is still visible. If one needs to debug an issue where the CI hangs and thus it is important to see which test causes this, the course of action is to temporarily increase the verbosity on the PR rather than global for everyone.In addition to the verbosity decrease, the PR also splits the prototype tests into three steps namely testing datasets, transforms, and models individually to make it even easier to find failing tests.