Skip to content

[proto] Added dict support for fill arg for remaining transforms #6599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Sep 19, 2022

Conversation

vfdev-5
Copy link
Collaborator

@vfdev-5 vfdev-5 commented Sep 16, 2022

Description:

  • fill arg can be int/float/sequence or dict of that.
  • Added support for other ops

Blocked by #6595

@vfdev-5 vfdev-5 force-pushed the proto-fill-as-dict-p2 branch from 4c40591 to bacc7dd Compare September 16, 2022 15:47
@datumbox
Copy link
Contributor

It should be merged prior continuing with #6584.

@vfdev-5 vfdev-5 marked this pull request as ready for review September 19, 2022 11:50
@vfdev-5 vfdev-5 requested review from pmeier and datumbox and removed request for pmeier September 19, 2022 11:52
Copy link
Collaborator

@pmeier pmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM when CI is green. Thanks Victor!

@vfdev-5 vfdev-5 merged commit dbbc5c8 into pytorch:main Sep 19, 2022
@vfdev-5 vfdev-5 deleted the proto-fill-as-dict-p2 branch September 19, 2022 13:35
@github-actions
Copy link

Hey @vfdev-5!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

facebook-github-bot pushed a commit that referenced this pull request Sep 23, 2022
…orms (#6599)

Summary:
* Updated fill arg typehint for affine, perspective and elastic ops

* Updated pad op on prototype side

* Code updates

* Few other minor updates

* WIP

* WIP

* Updates

* Update _image.py

* Fixed tests

Reviewed By: NicolasHug

Differential Revision: D39765301

fbshipit-source-id: ff56941d5bd673bde0349d442ff547821b0f0114
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants