add more KernelInfo's and DispatcherInfo's #6626
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmeier
changed the title
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 23, 2022
Summary:
* add KernelInfo for adjust_brightness
* add KernelInfo for adjust_contrast
* add KernelInfo for adjust_hue
* add KernelInfo for adjust_saturation
* add KernelInfo for clamp_bounding_box
* add KernelInfo for {five, ten}_crop_image_tensor as well as skip functionality
* add KernelInfo for normalize
* add KernelInfo for adjust_gamma
* cleanup
* add DispatcherInfo's for previously add KernelInfo's
* add dispatcher info for elastic
Reviewed By: NicolasHug
Differential Revision: D39765294
fbshipit-source-id: 42bdb40ead8807f60fc75fb9259dd34e2d4f0724
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses 1. from #6622. In addition to the added
{Kernel, Dispatcher}Info's this also introduces the ability to define test skips for specific tests on an info.That is useful if a test does not work at all for a kernel or dispatcher, e.g.
test_batched_vs_singleis hard to do for{five, ten}_crop_image_tensorsince the output is not a tensor, but rather a sequence of tensors. Plus, in some cases a specific parameter configuration does not work for a test, e.g. integersize's in{five, ten}_crop_image_tensorare not scriptable, so this can be individually skipped fortest_scripted_vs_eager.The same architecture can also be used for xfailing or fine tuning the tolerances, but so far there is no need for this so I didn't implement it yet.