Skip to content

Link for downloading SBU dataset has changed. Enable the test again #6638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 27, 2022

Conversation

ambujpawar
Copy link
Contributor

SBU seems to be working again. Therefore, removing it from expected failure test cases

Copy link
Collaborator

@pmeier pmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ambujpawar! The author never replied if we are allowed to publish the image archive rather than just the URL list. Thus, this is still the best we can do.

@pmeier pmeier requested a review from NicolasHug September 26, 2022 11:22
@pmeier
Copy link
Collaborator

pmeier commented Sep 27, 2022

@ambujpawar you don't need to regularly update your PR unless GH is showing you merge conflicts. We will update it before merge. Reviews might take some time since we experience some heavy internal workloads.

Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks both

@NicolasHug NicolasHug merged commit 55a436c into pytorch:main Sep 27, 2022
@github-actions
Copy link

Hey @NicolasHug!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

facebook-github-bot pushed a commit that referenced this pull request Sep 29, 2022
…6638)

Summary: Co-authored-by: Ambuj Pawar <[email protected]>

Reviewed By: YosuaMichael

Differential Revision: D39885424

fbshipit-source-id: f23fac5b87c64e57dc9b366e60b91f6506c5e4e1
@ambujpawar ambujpawar deleted the sbu_dataset_working_again branch November 4, 2022 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SBU download is failing
4 participants