Cleanup prototype kernel signatures #6648
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can merge first and I will fix them. |
Conflicts: torchvision/prototype/features/_bounding_box.py torchvision/prototype/transforms/functional/_geometry.py
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 7, 2022
Summary: * pass metadata directly after input in prototype kernels * rename img to image Reviewed By: datumbox Differential Revision: D40138734 fbshipit-source-id: 1b2207f08ff0f7deffa17cee06d644169d793647
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #6646 (comment). The second commit in the PR renames all instances of
imgtoimageon the prototype kernels. This was not discussed in the comment linked above, but goes in the same direction of aligning the kernel signatures as much as possible.