Skip to content

[cherry-pick] pin pyav to <10 (#6789) #6849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

YosuaMichael
Copy link
Contributor

Cherry-pick #6789

  • pin pyav to <10

  • pin av in GHA workflows as well

  • also pin in M1 workflow

* pin pyav to <10

* pin av in GHA workflows as well

* also pin in M1 workflow
@YosuaMichael
Copy link
Contributor Author

YosuaMichael commented Oct 27, 2022

@atalman sorry for the very last minute, I miss this fix because it is not labeled as bug, however this is needed to fix the video test.

@YosuaMichael
Copy link
Contributor Author

After discussing with @atalman , this change will only affect the test/ci and not the release binary, hence not so critical. Since it is already too late for the binary, we will not cherry-pick this PR.

I will close the PR after the all the test is done.

@atalman
Copy link
Contributor

atalman commented Dec 9, 2022

This cherry pick to resolve this error in the release:

FAILED test/test_io.py::TestVideo::test_write_video_with_audio - IndexError: tuple index out of range

During M1 unit test
https://github.com/pytorch/vision/actions/runs/3654003271/jobs/6183357261

Copy link
Contributor

@datumbox datumbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@atalman atalman merged commit 0504df5 into pytorch:release/0.14 Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants