[prototype] Adjust solarize threshold on input type #6874
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datumbox
commented
Oct 31, 2022
| @@ -137,7 +137,8 @@ def _apply_image_or_video_transform( | |||
| elif transform_id == "Posterize": | |||
| return F.posterize(image, bits=int(magnitude)) | |||
| elif transform_id == "Solarize": | |||
| return F.solarize(image, threshold=magnitude) | |||
| bound = 1.0 if image.is_floating_point() else 255.0 | |||
datumbox
changed the title
pmeier
approved these changes
Oct 31, 2022
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 4, 2022
Summary: * Adjust solarize threshold on input type * Handle PIL images * minor refactor * Fix linter Reviewed By: datumbox Differential Revision: D41020549 fbshipit-source-id: 100cf505acd93e86d46e193addc99fbb4c23e3d0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6840
This PR makes it possible for float images to use AutoAugmentation methods. Given that now all operators support float images, the only change necessary is to adjust the thresholds of solarize to depend on the max value of the input type (1.0 for floats, 255 for integers or PIL).
cc @vfdev-5 @bjuncek @pmeier