Skip to content

[prototype] Port elastic and minor cleanups #6942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 10, 2022

Conversation

datumbox
Copy link
Contributor

@datumbox datumbox commented Nov 10, 2022

Related to #6818

This PR:

  • Ports _FT.elastic_transform to V2 in order to make use of some optimizations done by @vfdev-5 on the _create_identity_grid()
  • Does minor perf on autocontrast_image_tensor() and _affine_bounding_box_xyxy()
  • Does minor clean ups on various methods, none of which affect accuracy

Given the original optimisation was done by Victor for the boxes and it was beneficial, I'm not measuring it again. Happy to do so, if we want.

cc @vfdev-5 @bjuncek @pmeier

Copy link
Collaborator

@pmeier pmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is green!

@datumbox datumbox merged commit 70edf96 into pytorch:main Nov 10, 2022
@datumbox datumbox deleted the cleanup/elastic branch November 10, 2022 15:48
facebook-github-bot pushed a commit that referenced this pull request Nov 14, 2022
Summary:
* Port elastic and minor cleanups

* Update torchvision/prototype/transforms/functional/_geometry.py

Reviewed By: NicolasHug

Differential Revision: D41265205

fbshipit-source-id: c62a7764bc7bf3efecb9bbb24ce1f192226c4438

Co-authored-by: Philip Meier <[email protected]>
Co-authored-by: Philip Meier <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants