Skip to content

[prototype] Optimize and clean up all affine methods #6945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Nov 14, 2022
Merged

[prototype] Optimize and clean up all affine methods #6945

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
3ac06ad
Clean up `_get_inverse_affine_matrix` and `_compute_affine_output_size`
datumbox Nov 11, 2022
62deb43
Optimize `_apply_grid_transform`
datumbox Nov 11, 2022
2f0d763
Cleanup `_assert_grid_transform_inputs`
datumbox Nov 11, 2022
dca1923
Fix bugs on `_pad_with_scalar_fill` & `crop_mask` and port `crop_imag…
datumbox Nov 11, 2022
b5548ec
Call directly `_pad_with_scalar_fill`
datumbox Nov 11, 2022
709b34a
Fix linter
datumbox Nov 11, 2022
3c38b97
Merge branch 'main' into perf/affine
datumbox Nov 11, 2022
b9a6e74
Clean up `center_crop_image_tensor`
datumbox Nov 11, 2022
62b9d47
Fix comments.
datumbox Nov 14, 2022
b3a0bb1
Fixing rounding issues.
datumbox Nov 14, 2022
8e110f6
Bumping tolerance for rotate which is unrelated to this PR.
datumbox Nov 14, 2022
555df2d
Fix tolerance threshold for RandomPerspective.
datumbox Nov 14, 2022
5c1f433
Merge branch 'main' into perf/affine
datumbox Nov 14, 2022
a32be72
Clean up `_affine_grid` and `affine_image_tensor`
datumbox Nov 14, 2022
311ff85
Clean up `rotate_image_tensor`
datumbox Nov 14, 2022
6644006
Fixing linter
datumbox Nov 14, 2022
d3639e0
Address code-review comments.
datumbox Nov 14, 2022
548ef68
Merge branch 'main' into perf/affine
datumbox Nov 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/prototype_transforms_kernel_infos.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -915,7 +915,7 @@ def sample_inputs_rotate_video():
reference_inputs_fn=reference_inputs_rotate_image_tensor,
float32_vs_uint8=True,
# TODO: investigate
closeness_kwargs=pil_reference_pixel_difference(100, agg_method="mean"),
closeness_kwargs=pil_reference_pixel_difference(110, agg_method="mean"),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flaky test unrelated to this PR that popped up previously on another PR:

Unrelated flakiness:
FAILED test/test_prototype_transforms_functional.py::TestKernels::test_against_reference[rotate_image_tensor-38] - AssertionError: The 'mean' of the absolute difference is 104.21571906354515, but only 100.0 is allowed.

test_marks=[
xfail_jit_tuple_instead_of_list("fill"),
# TODO: check if this is a regression since it seems that should be supported if `int` is ok
Expand Down
1 change: 1 addition & 0 deletions test/test_prototype_transforms_consistency.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,6 +401,7 @@ def __init__(
ArgsKwargs(p=1, distortion_scale=0.1, fill=1),
ArgsKwargs(p=1, distortion_scale=0.4, fill=(1, 2, 3)),
],
closeness_kwargs={"atol": None, "rtol": None},
),
ConsistencyConfig(
prototype_transforms.RandomRotation,
Expand Down
Loading