Relax mypy in prototype namespace #7091
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmeier
commented
Jan 16, 2023
| @@ -7,7 +7,7 @@ allow_redefinition = True | |||
| no_implicit_optional = True | |||
| warn_redundant_casts = True | |||
|
|
|||
| [mypy-torchvision.prototype.features.*] | |||
pmeier
commented
Jan 16, 2023
| @@ -98,7 +98,7 @@ def __torch_function__( | |||
| # `args = (torch.Tensor(), datapoints.Image())` first. Without this guard, the original `torch.Tensor` would | |||
| # be wrapped into a `datapoints.Image`. | |||
| if wrapper and isinstance(args[0], cls): | |||
| return wrapper(cls, args[0], output) # type: ignore[no-any-return] | |||
| return wrapper(cls, args[0], output) | |||
There was a problem hiding this comment.
No longer needed without the extra strictness.
|
Hey @pmeier! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jan 24, 2023
Reviewed By: YosuaMichael Differential Revision: D42706912 fbshipit-source-id: cc7e003fe5e17772304d52b346f78d5182fdb005
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See 2. in #7084 (review).
cc @bjuncek