add ffmpeg to Linux CPU and GPU unittest workflows #7295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmeier
commented
Feb 21, 2023
| @@ -39,7 +39,7 @@ jobs: | |||
| fi | |||
|
|
|||
| # Create Conda Env | |||
| conda create -yp ci_env python="${PYTHON_VERSION}" numpy libpng jpeg scipy | |||
| conda create -yp ci_env python="${PYTHON_VERSION}" numpy libpng jpeg scipy 'ffmpeg<4.3' | |||
There was a problem hiding this comment.
See #7296 for why we need the <4.3 pin
|
Hey @pmeier! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
NicolasHug
pushed a commit
to NicolasHug/vision
that referenced
this pull request
Feb 24, 2023
This was referenced Feb 24, 2023
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 29, 2023
Reviewed By: vmoens Differential Revision: D44416636 fbshipit-source-id: a6e58468d2f0d1b093e7468f11d791e137008867
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our current GHA workflows do not build against
ffmpegsince it is not installed: https://github.com/pytorch/vision/actions/runs/4206146225/jobs/7299225421#step:10:1868However, this was the case before when the workflows ran on CircleCI: https://app.circleci.com/pipelines/github/pytorch/vision/22145/workflows/dda25a3d-9c31-4d81-bc5e-c94fbc8d8566/jobs/1790112?invite=true#step-107-74
We specified it with
vision/.circleci/unittest/linux/scripts/setup_env.sh
Lines 39 to 44 in 474d87b
but something similar is missing from the new GHA workflows. This PR adds it.
cc @seemethere