-
Notifications
You must be signed in to change notification settings - Fork 7.1k
align transforms v2 signatures with v1 #7301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. OK to merge once CI is green
Thanks @pmeier
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Philip
Failures are unrelated. https://github.com/pytorch/vision/actions/runs/4241568469/jobs/7371959012
|
Co-authored-by: vfdev <[email protected]>
Summary: Co-authored-by: vfdev <[email protected]> Reviewed By: vmoens Differential Revision: D44416615 fbshipit-source-id: 1d3472c527f298a7be96162bb2db72ed387df82c
We wanted to enforce that before, but previously the test did not check the order of the signature. This PR makes the test more strict and fixes the broken signatures.
cc @vfdev-5 @bjuncek