Skip to content

align transforms v2 signatures with v1 #7301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 22, 2023

Conversation

pmeier
Copy link
Collaborator

@pmeier pmeier commented Feb 22, 2023

We wanted to enforce that before, but previously the test did not check the order of the signature. This PR makes the test more strict and fixes the broken signatures.

cc @vfdev-5 @bjuncek

Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. OK to merge once CI is green
Thanks @pmeier

Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Philip

@vfdev-5
Copy link
Collaborator

vfdev-5 commented Feb 22, 2023

Failures are unrelated.

https://github.com/pytorch/vision/actions/runs/4241568469/jobs/7371959012

2023-02-22T10:33:59.4454583Z �[36m�[1m=========================== short test summary info ============================�[0m
2023-02-22T10:33:59.4455193Z �[31mFAILED�[0m test/test_transforms.py::�[1mtest_functional_deprecation_warning[True-from torchvision.transforms import functional_pil]�[0m - RuntimeError: script errored with output:
2023-02-22T10:33:59.4455726Z Error: mkl-service + Intel(R) MKL: MKL_THREADING_LAYER=INTEL is incompatible with libgomp.so.1 library.
2023-02-22T10:33:59.4456102Z 	Try to import numpy first or set the threading layer accordingly. Set MKL_SERVICE_FORCE_INTEL to force it.
2023-02-22T10:33:59.4456707Z �[31mFAILED�[0m test/test_transforms.py::�[1mtest_functional_deprecation_warning[True-from torchvision.transforms import functional_tensor]�[0m - RuntimeError: script errored with output:
2023-02-22T10:33:59.4457239Z Error: mkl-service + Intel(R) MKL: MKL_THREADING_LAYER=INTEL is incompatible with libgomp.so.1 library.
2023-02-22T10:33:59.4457594Z 	Try to import numpy first or set the threading layer accordingly. Set MKL_SERVICE_FORCE_INTEL to force it.
2023-02-22T10:33:59.4458219Z �[31mFAILED�[0m test/test_transforms.py::�[1mtest_functional_deprecation_warning[True-from torchvision.transforms.functional_tensor import resize]�[0m - RuntimeError: script errored with output:
2023-02-22T10:33:59.4458828Z Error: mkl-service + Intel(R) MKL: MKL_THREADING_LAYER=INTEL is incompatible with libgomp.so.1 library.
2023-02-22T10:33:59.4459196Z 	Try to import numpy first or set the threading layer accordingly. Set MKL_SERVICE_FORCE_INTEL to force it.
2023-02-22T10:33:59.4459805Z �[31mFAILED�[0m test/test_transforms.py::�[1mtest_functional_deprecation_warning[True-from torchvision.transforms.functional_pil import resize]�[0m - RuntimeError: script errored with output:
2023-02-22T10:33:59.4460345Z Error: mkl-service + Intel(R) MKL: MKL_THREADING_LAYER=INTEL is incompatible with libgomp.so.1 library.
2023-02-22T10:33:59.4460716Z 	Try to import numpy first or set the threading layer accordingly. Set MKL_SERVICE_FORCE_INTEL to force it.
2023-02-22T10:33:59.4461319Z �[31mFAILED�[0m test/test_transforms.py::�[1mtest_functional_deprecation_warning[False-from torchvision.transforms import functional_pil]�[0m - RuntimeError: script errored with output:
2023-02-22T10:33:59.4461831Z Error: mkl-service + Intel(R) MKL: MKL_THREADING_LAYER=INTEL is incompatible with libgomp.so.1 library.
2023-02-22T10:33:59.4462202Z 	Try to import numpy first or set the threading layer accordingly. Set MKL_SERVICE_FORCE_INTEL to force it.
2023-02-22T10:33:59.4462810Z �[31mFAILED�[0m test/test_transforms.py::�[1mtest_functional_deprecation_warning[False-from torchvision.transforms import functional_tensor]�[0m - RuntimeError: script errored with output:
2023-02-22T10:33:59.4463339Z Error: mkl-service + Intel(R) MKL: MKL_THREADING_LAYER=INTEL is incompatible with libgomp.so.1 library.
2023-02-22T10:33:59.4463695Z 	Try to import numpy first or set the threading layer accordingly. Set MKL_SERVICE_FORCE_INTEL to force it.
2023-02-22T10:33:59.4464321Z �[31mFAILED�[0m test/test_transforms.py::�[1mtest_functional_deprecation_warning[False-from torchvision.transforms.functional_tensor import resize]�[0m - RuntimeError: script errored with output:
2023-02-22T10:33:59.4464860Z Error: mkl-service + Intel(R) MKL: MKL_THREADING_LAYER=INTEL is incompatible with libgomp.so.1 library.
2023-02-22T10:33:59.4465224Z 	Try to import numpy first or set the threading layer accordingly. Set MKL_SERVICE_FORCE_INTEL to force it.
2023-02-22T10:33:59.4465835Z �[31mFAILED�[0m test/test_transforms.py::�[1mtest_functional_deprecation_warning[False-from torchvision.transforms.functional_pil import resize]�[0m - RuntimeError: script errored with output:
2023-02-22T10:33:59.4466373Z Error: mkl-service + Intel(R) MKL: MKL_THREADING_LAYER=INTEL is incompatible with libgomp.so.1 library.
2023-02-22T10:33:59.4466778Z 	Try to import numpy first or set the threading layer accordingly. Set MKL_SERVICE_FORCE_INTEL to force it.
2023-02-22T10:33:59.4467346Z �[31mFAILED�[0m test/test_transforms_v2.py::�[1mtest_warnings_v2_namespaces[True-from torchvision.transforms import v2]�[0m - RuntimeError: script errored with output:
2023-02-22T10:33:59.4467831Z Error: mkl-service + Intel(R) MKL: MKL_THREADING_LAYER=INTEL is incompatible with libgomp.so.1 library.
2023-02-22T10:33:59.4468194Z 	Try to import numpy first or set the threading layer accordingly. Set MKL_SERVICE_FORCE_INTEL to force it.
2023-02-22T10:33:59.4468760Z �[31mFAILED�[0m test/test_transforms_v2.py::�[1mtest_warnings_v2_namespaces[True-import torchvision.transforms.v2]�[0m - RuntimeError: script errored with output:
2023-02-22T10:33:59.4469261Z Error: mkl-service + Intel(R) MKL: MKL_THREADING_LAYER=INTEL is incompatible with libgomp.so.1 library.
2023-02-22T10:33:59.4469620Z 	Try to import numpy first or set the threading layer accordingly. Set MKL_SERVICE_FORCE_INTEL to force it.
2023-02-22T10:33:59.4470205Z �[31mFAILED�[0m test/test_transforms_v2.py::�[1mtest_warnings_v2_namespaces[True-from torchvision.transforms.v2 import Resize]�[0m - RuntimeError: script errored with output:
2023-02-22T10:33:59.4470717Z Error: mkl-service + Intel(R) MKL: MKL_THREADING_LAYER=INTEL is incompatible with libgomp.so.1 library.
2023-02-22T10:33:59.4471123Z 	Try to import numpy first or set the threading layer accordingly. Set MKL_SERVICE_FORCE_INTEL to force it.
2023-02-22T10:33:59.4471703Z �[31mFAILED�[0m test/test_transforms_v2.py::�[1mtest_warnings_v2_namespaces[True-import torchvision.transforms.v2.functional]�[0m - RuntimeError: script errored with output:
2023-02-22T10:33:59.4472224Z Error: mkl-service + Intel(R) MKL: MKL_THREADING_LAYER=INTEL is incompatible with libgomp.so.1 library.
2023-02-22T10:33:59.4472591Z 	Try to import numpy first or set the threading layer accordingly. Set MKL_SERVICE_FORCE_INTEL to force it.
2023-02-22T10:33:59.4473200Z �[31mFAILED�[0m test/test_transforms_v2.py::�[1mtest_warnings_v2_namespaces[True-from torchvision.transforms.v2.functional import resize]�[0m - RuntimeError: script errored with output:
2023-02-22T10:33:59.4473718Z Error: mkl-service + Intel(R) MKL: MKL_THREADING_LAYER=INTEL is incompatible with libgomp.so.1 library.
2023-02-22T10:33:59.4474090Z 	Try to import numpy first or set the threading layer accordingly. Set MKL_SERVICE_FORCE_INTEL to force it.
2023-02-22T10:33:59.4474648Z �[31mFAILED�[0m test/test_transforms_v2.py::�[1mtest_warnings_v2_namespaces[True-from torchvision import datapoints]�[0m - RuntimeError: script errored with output:
2023-02-22T10:33:59.4475138Z Error: mkl-service + Intel(R) MKL: MKL_THREADING_LAYER=INTEL is incompatible with libgomp.so.1 library.
2023-02-22T10:33:59.4475487Z 	Try to import numpy first or set the threading layer accordingly. Set MKL_SERVICE_FORCE_INTEL to force it.
2023-02-22T10:33:59.4476064Z �[31mFAILED�[0m test/test_transforms_v2.py::�[1mtest_warnings_v2_namespaces[True-from torchvision.datapoints import Image]�[0m - RuntimeError: script errored with output:
2023-02-22T10:33:59.4476564Z Error: mkl-service + Intel(R) MKL: MKL_THREADING_LAYER=INTEL is incompatible with libgomp.so.1 library.
2023-02-22T10:33:59.4476930Z 	Try to import numpy first or set the threading layer accordingly. Set MKL_SERVICE_FORCE_INTEL to force it.
2023-02-22T10:33:59.4477523Z �[31mFAILED�[0m test/test_transforms_v2.py::�[1mtest_warnings_v2_namespaces[True-from torchvision.datasets import wrap_dataset_for_transforms_v2]�[0m - RuntimeError: script errored with output:
2023-02-22T10:33:59.4478044Z Error: mkl-service + Intel(R) MKL: MKL_THREADING_LAYER=INTEL is incompatible with libgomp.so.1 library.
2023-02-22T10:33:59.4478410Z 	Try to import numpy first or set the threading layer accordingly. Set MKL_SERVICE_FORCE_INTEL to force it.
2023-02-22T10:33:59.4479034Z �[31mFAILED�[0m test/test_transforms_v2.py::�[1mtest_warnings_v2_namespaces[False-from torchvision.transforms import v2]�[0m - RuntimeError: script errored with output:
2023-02-22T10:33:59.4479516Z Error: mkl-service + Intel(R) MKL: MKL_THREADING_LAYER=INTEL is incompatible with libgomp.so.1 library.
2023-02-22T10:33:59.4479882Z 	Try to import numpy first or set the threading layer accordingly. Set MKL_SERVICE_FORCE_INTEL to force it.
2023-02-22T10:33:59.4480455Z �[31mFAILED�[0m test/test_transforms_v2.py::�[1mtest_warnings_v2_namespaces[False-import torchvision.transforms.v2]�[0m - RuntimeError: script errored with output:
2023-02-22T10:33:59.4480955Z Error: mkl-service + Intel(R) MKL: MKL_THREADING_LAYER=INTEL is incompatible with libgomp.so.1 library.
2023-02-22T10:33:59.4481308Z 	Try to import numpy first or set the threading layer accordingly. Set MKL_SERVICE_FORCE_INTEL to force it.
2023-02-22T10:33:59.4481890Z �[31mFAILED�[0m test/test_transforms_v2.py::�[1mtest_warnings_v2_namespaces[False-from torchvision.transforms.v2 import Resize]�[0m - RuntimeError: script errored with output:
2023-02-22T10:33:59.4482612Z Error: mkl-service + Intel(R) MKL: MKL_THREADING_LAYER=INTEL is incompatible with libgomp.so.1 library.
2023-02-22T10:33:59.4482981Z 	Try to import numpy first or set the threading layer accordingly. Set MKL_SERVICE_FORCE_INTEL to force it.
2023-02-22T10:33:59.4483565Z �[31mFAILED�[0m test/test_transforms_v2.py::�[1mtest_warnings_v2_namespaces[False-import torchvision.transforms.v2.functional]�[0m - RuntimeError: script errored with output:
2023-02-22T10:33:59.4484147Z Error: mkl-service + Intel(R) MKL: MKL_THREADING_LAYER=INTEL is incompatible with libgomp.so.1 library.
2023-02-22T10:33:59.4484516Z 	Try to import numpy first or set the threading layer accordingly. Set MKL_SERVICE_FORCE_INTEL to force it.
2023-02-22T10:33:59.4485130Z �[31mFAILED�[0m test/test_transforms_v2.py::�[1mtest_warnings_v2_namespaces[False-from torchvision.transforms.v2.functional import resize]�[0m - RuntimeError: script errored with output:
2023-02-22T10:33:59.4485645Z Error: mkl-service + Intel(R) MKL: MKL_THREADING_LAYER=INTEL is incompatible with libgomp.so.1 library.
2023-02-22T10:33:59.4486015Z 	Try to import numpy first or set the threading layer accordingly. Set MKL_SERVICE_FORCE_INTEL to force it.
2023-02-22T10:33:59.4486575Z �[31mFAILED�[0m test/test_transforms_v2.py::�[1mtest_warnings_v2_namespaces[False-from torchvision import datapoints]�[0m - RuntimeError: script errored with output:
2023-02-22T10:33:59.4487070Z Error: mkl-service + Intel(R) MKL: MKL_THREADING_LAYER=INTEL is incompatible with libgomp.so.1 library.
2023-02-22T10:33:59.4487424Z 	Try to import numpy first or set the threading layer accordingly. Set MKL_SERVICE_FORCE_INTEL to force it.
2023-02-22T10:33:59.4488000Z �[31mFAILED�[0m test/test_transforms_v2.py::�[1mtest_warnings_v2_namespaces[False-from torchvision.datapoints import Image]�[0m - RuntimeError: script errored with output:
2023-02-22T10:33:59.4488499Z Error: mkl-service + Intel(R) MKL: MKL_THREADING_LAYER=INTEL is incompatible with libgomp.so.1 library.
2023-02-22T10:33:59.4488854Z 	Try to import numpy first or set the threading layer accordingly. Set MKL_SERVICE_FORCE_INTEL to force it.
2023-02-22T10:33:59.4489463Z �[31mFAILED�[0m test/test_transforms_v2.py::�[1mtest_warnings_v2_namespaces[False-from torchvision.datasets import wrap_dataset_for_transforms_v2]�[0m - RuntimeError: script errored with output:
2023-02-22T10:33:59.4489986Z Error: mkl-service + Intel(R) MKL: MKL_THREADING_LAYER=INTEL is incompatible with libgomp.so.1 library.
2023-02-22T10:33:59.4490355Z 	Try to import numpy first or set the threading layer accordingly. Set MKL_SERVICE_FORCE_INTEL to force it.
2023-02-22T10:33:59.4490835Z �[31mFAILED�[0m test/test_transforms_v2.py::�[1mtest_no_warnings_v1_namespace�[0m - RuntimeError: script errored with output:
2023-02-22T10:33:59.4491286Z Error: mkl-service + Intel(R) MKL: MKL_THREADING_LAYER=INTEL is incompatible with libgomp.so.1 library.
2023-02-22T10:33:59.4491720Z 	Try to import numpy first or set the threading layer accordingly. Set MKL_SERVICE_FORCE_INTEL to force it.
2023-02-22T10:33:59.4723506Z �[31m= �[31m�[1m25 failed�[0m, �[32m74315 passed�[0m, �[33m73096 skipped�[0m, �[33m1629 xfailed�[0m, �[33m4630 warnings�[0m�[31m in 1512.64s (0:25:12)�[0m�[31m =�[0m

@vfdev-5 vfdev-5 merged commit a46d97c into pytorch:main Feb 22, 2023
@pmeier pmeier deleted the transforms-signature branch February 22, 2023 14:40
NicolasHug pushed a commit to NicolasHug/vision that referenced this pull request Feb 24, 2023
facebook-github-bot pushed a commit that referenced this pull request Mar 29, 2023
Summary: Co-authored-by: vfdev <[email protected]>

Reviewed By: vmoens

Differential Revision: D44416615

fbshipit-source-id: 1d3472c527f298a7be96162bb2db72ed387df82c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants