-
Notifications
You must be signed in to change notification settings - Fork 7.1k
Add v2 docs for color transforms #7310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @NicolasHug !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor nit, otherwise LGTM. Thanks Nicolas!
@@ -199,10 +224,10 @@ class RandomPhotometricDistort(Transform): | |||
|
|||
def __init__( | |||
self, | |||
brightness: Tuple[float, float] = (0.875, 1.125), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just to align the signature with the logic below, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes sorry I forgot to comment - this is to align with the signature of ColorJitter
Hey @NicolasHug! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
Reviewed By: vmoens Differential Revision: D44416564 fbshipit-source-id: 15c1b601acfe8fadd239b1709b1ea24a46f70ea5
No description provided.