add docs for datapoints #7312
Merged
add docs for datapoints #7312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolasHug
reviewed
Feb 23, 2023
|
@NicolasHug sphinx fails to add cross links for
Any idea how to get around that? |
|
for |
Doesn't work 😞
|
|
As discussed offline, this is a more general issue and not related to this PR. |
|
Hey @NicolasHug! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
NicolasHug
added a commit
to NicolasHug/vision
that referenced
this pull request
Feb 24, 2023
Co-authored-by: Nicolas Hug <[email protected]>
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 30, 2023
Summary: Co-authored-by: Nicolas Hug <[email protected]> Reviewed By: vmoens Differential Revision: D44416598 fbshipit-source-id: 22edbeefe525cd728cc8a1de97e996f9c946b282
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I only added the skeleton and added proper docstrings for
BoundingBoxandBoundingBoxFormat. The other ones have just copy-pasted docstrings since sphinx wouldn't build without.Given that we are going to copy paste for all other datapoints, this can already be reviewed. I'll send proper docstrings for everything when we have reached consensus on what it should look like.