Fixed uncaught warnings in tests v2 #7330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolasHug
approved these changes
Feb 24, 2023
Comment on lines
+1794
to
+1799
| if to_tensor is transforms.ToTensor: | ||
| with pytest.warns(UserWarning, match="deprecated and will be removed"): | ||
| to_tensor = to_tensor() | ||
| else: | ||
| to_tensor = to_tensor() | ||
|
|
There was a problem hiding this comment.
super nit, just fyi for those kind of cases we can use something like
cm = pytest.warns(...) if ... else contextlib.nullcontext()
with cm:
to_tensor = to_tensor()
|
Hey @NicolasHug! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
NicolasHug
added a commit
to NicolasHug/vision
that referenced
this pull request
Feb 24, 2023
Co-authored-by: Nicolas Hug <[email protected]>
This was referenced Feb 24, 2023
This was referenced Mar 16, 2023
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 30, 2023
Summary: Co-authored-by: Nicolas Hug <[email protected]> Reviewed By: vmoens Differential Revision: D44416628 fbshipit-source-id: 17a34a28d35b35692ec59997da4b027095333914
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.