Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add macOS unittest to GHA #7376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add macOS unittest to GHA #7376
Changes from all commits
beed393
cdb2697
3b89814
773412d
5da3f42
19402ef
5e2253d
5fb92ff
03ba33b
6a10cc6
8925969
94db606
8b8bc87
90210c1
893df7b
f76c795
da828de
914a1e0
c46fb06
140f383
b265117
4145d70
68049f0
5b32e26
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are doing the same for the macOS wheel workflows:
vision/packaging/pre_build_script.sh
Lines 3 to 9 in 0e62c34
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small drive-by that helped me debug. We do the same for PNG already:
vision/setup.py
Lines 278 to 279 in 0e62c34
I wasn't able to get the version of the library in a way that would hold for all operating systems. I guess knowing the location is good enough.