Added progress flag to model getters #875
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 26, 2019 22:20
Codecov Report
@@ Coverage Diff @@
## master #875 +/- ##
=========================================
+ Coverage 55.17% 55.9% +0.73%
=========================================
Files 36 37 +1
Lines 3375 3338 -37
Branches 553 531 -22
=========================================
+ Hits 1862 1866 +4
+ Misses 1375 1357 -18
+ Partials 138 115 -23
Continue to review full report at Codecov.
|
fmassa
reviewed
Apr 27, 2019
fmassa
pushed a commit
that referenced
this pull request
May 7, 2019
* Minor refactoring of ShuffleNetV2 Added progress flag following #875. Further the following refactoring was also done: 1) added `version` argument in shufflenetv2 method and removed the operations for converting the `width_mult` arg to float and string. 2) removed `num_classes` argument and **kwargs from functions except `ShuffleNetV2` * removed `version` arg * Update shufflenetv2.py * Removed the try except block * Update shufflenetv2.py * Changed version from float to str * Replace `width_mult` with `stages_out_channels` Removes the need of `_getStages` function.
fmassa
pushed a commit
that referenced
this pull request
Jun 11, 2019
This PR uses a protected method for loading and initializing the segmentation models. Relevant #875
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for disabling the display of the download progress as requested in #862. It depends on
torch.hub.load_state_dict_from_url, which is not included in the latest stable release. Thus, this PR will not pass the CI until #826 is merged as @fmassa mentioned.I also did some refactoring along the way:
models with multiple different architectures (DenseNet,ResNet,SqueezeNet, andVGG) I added a protected function that allmodelgetter functions use.versionidentifier inSqueezeNetfromfloattostr(e.g.1.0to'1_0').Edit: Apparently this passed CI checks. Beats me why though.