Skip to content

clamping_mode: Rename 'none' to None and None to 'auto' #9132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Jul 1, 2025

Conversation

NicolasHug
Copy link
Member

@NicolasHug NicolasHug commented Jun 30, 2025

This PR allows the clamping_mode attribute of a BoundingBoxes object to be None instead of "none".
It also changes the default value of clamping_mode parameter in ClampingBoundingBoxes from None to "auto" to resolve a resulting conflict.

cc @vfdev-5

Copy link

pytorch-bot bot commented Jun 30, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/9132

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit dc07d27 with merge base 80cb38e (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copy link
Member

@AntoineSimoulin AntoineSimoulin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me. Thanks for the PR @NicolasHug!

@NicolasHug NicolasHug merged commit 080bf2f into pytorch:main Jul 1, 2025
58 checks passed
Copy link

github-actions bot commented Jul 1, 2025

Hey @NicolasHug!

You merged this PR, but no labels were added.
The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

AntoineSimoulin added a commit to AntoineSimoulin/vision that referenced this pull request Jul 1, 2025
facebook-github-bot pushed a commit that referenced this pull request Jul 31, 2025
Summary: Co-authored-by: Antoine Simoulin <[email protected]>

Reviewed By: AntoineSimoulin

Differential Revision: D79175061

fbshipit-source-id: 8917698aca2a4c1a2702c17196984c141079af70
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants