-
Notifications
You must be signed in to change notification settings - Fork 7.1k
clamping_mode: Rename 'none' to None and None to 'auto' #9132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Test Plan: ```bash pytest test/test_transforms_v2.py -k box -v ```
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/9132
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit dc07d27 with merge base 80cb38e ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good to me. Thanks for the PR @NicolasHug!
Hey @NicolasHug! You merged this PR, but no labels were added. |
Co-authored-by: Antoine Simoulin <[email protected]>
Summary: Co-authored-by: Antoine Simoulin <[email protected]> Reviewed By: AntoineSimoulin Differential Revision: D79175061 fbshipit-source-id: 8917698aca2a4c1a2702c17196984c141079af70
This PR allows the
clamping_mode
attribute of aBoundingBoxes
object to beNone
instead of"none"
.It also changes the default value of
clamping_mode
parameter inClampingBoundingBoxes
fromNone
to"auto"
to resolve a resulting conflict.cc @vfdev-5