Skeleton for rotated bounding box tutorial #9140
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/9140
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit f6d1838 with merge base d247de8 ( BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Thanks a lot for the PR!
Let's try to add
They LGTM, we can add more examples for rotation and elastic which I think will also address the point below:
There probably is an actual fix for this, but I don't know it from the top of my head, and fighting with matplotlib is a challenge. Although, chatgpt should be able to help now. In any case for both RandomRotation and Elastic, we can just call them 5 times and show 5 different images since these transformations are random?
We can modify the plotting helper as we please, it's something I wrote specifically for the tutorial. We can just add a new |
| ], | ||
| format="CXCYWHR", | ||
| canvas_size=(orig_img.size[1], orig_img.size[0]), | ||
| clamping_mode="hard", |
There was a problem hiding this comment.
I think we should omit setting clamping_mode here, so that we illustrate the behavior of the boxes with their default clamping_mode: soft.
| # TODO: why is this necessary? | ||
| orig_box = v2.ConvertBoundingBoxFormat("xyxyxyxy")(orig_box) |
There was a problem hiding this comment.
I figured out why, explained in code comments.
| # Clamping Modes | ||
| # -------------- | ||
| # Explain hard and soft, with appropriate links to documentation. Talk about | ||
| # defaults. Link to to-be-written-tutorial on mode-setting in general. |
There was a problem hiding this comment.
Maybe we can write the tutorial on mode-setting here in this same tutorial? It might make it easier to for users to find all the relevant info in one single place. Obviously this can be done in a separate PR
Reviewed By: AntoineSimoulin Differential Revision: D79175028 fbshipit-source-id: 8ed8fef904151637a5cbedfd76cd2c0e6e4a0b19
This is obviously not even a draft, but rather the skeleton of what the tutorial will cover. I'd like to defer the actual language of the text to later, and instead focus on:
width=3) in there. Ideas?We'll want to have figures that shows what happens with the bounding boxes - let's also leave that to later.