Skip to content

Conversation

miladm
Copy link
Collaborator

@miladm miladm commented Jul 14, 2022

No description provided.

@miladm
Copy link
Collaborator Author

miladm commented Aug 18, 2022

The latest commit succeeds at passing the nonzero -> expand unit test in c++. Below is the output of test/cpp/build/test_ptxla --gtest_filter=AtenXlaTensorTest.TestExpandSymInt

*Ran nonzero
added the node
*is test symbolic: 1
*xla_y.sym_sizes()[0] SymInt(-9223232436526075024) is_symbolic: 1
*xla_y.sym_sizes()[1] SymInt(1) is_symbolic: 0
*xla_a
*Ran expand_symint
*xla_b.sym_sizes()[0]: added the node SymInt(-9223372036768888736) is_symbolic: 1
*xla_b.sym_sizes()[1]: SymInt(3) is_symbolic: 0
*xla_b.sym_sizes()[2]: SymInt(4) is_symbolic: 0
In SetDimensionSizes
In SetDimensionSizes loop 0                     <-- SetDimensionSize is not set correctly
In SetDimensionSizes loop 1
In SetDimensionSizes loop 2
*Ran AllClose
*Ran ExpectCounterNotChanged
*Ran ExpectCounterChanged
[       OK ] AtenXlaTensorTest.TestExpandSymInt (274 ms)
[----------] 1 test from AtenXlaTensorTest (274 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test suite ran. (274 ms total)
[  PASSED  ] 1 test.

This is great.

Next issues to resolve:

CC @JackCaoG @Krovatkin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dynamism Dynamic Shape Features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lazySymIntNode->node_ segfaults on simple dynamic tensor conversation between SymInt and toSymIntNodeImpl
1 participant