Skip to content

Fix nightly/unstable CI URL #1578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 18, 2021
Merged

Fix nightly/unstable CI URL #1578

merged 2 commits into from
Apr 18, 2021

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Feb 26, 2021

@djhoese djhoese requested a review from mraspaud as a code owner February 26, 2021 19:37
@djhoese djhoese self-assigned this Feb 26, 2021
@codecov
Copy link

codecov bot commented Feb 26, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@7aa706b). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1578   +/-   ##
=========================================
  Coverage          ?   92.62%           
=========================================
  Files             ?      258           
  Lines             ?    37810           
  Branches          ?        0           
=========================================
  Hits              ?    35022           
  Misses            ?     2788           
  Partials          ?        0
Flag Coverage Δ
behaviourtests 4.81% <ø> (?)
unittests 92.76% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7aa706b...3b14b25. Read the comment docs.

@djhoese djhoese mentioned this pull request Feb 26, 2021
Closed
mraspaud
mraspaud approved these changes Mar 2, 2021
View reviewed changes
Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Is this good to merge?

@djhoese
Copy link
Member Author

djhoese commented Mar 2, 2021

No. See MacPython/scipy-wheels#114

@mraspaud mraspaud added blocked Waiting on an external action (eg release of other package) bug labels Mar 2, 2021
@djhoese
Copy link
Member Author

djhoese commented Apr 18, 2021

This PR is still failing to pull in the new wheels, but this is only because the old wheels are still listed on the target URL. The scipy dev has asked those with admin privileges to remove these old packages and then this should be working.

@djhoese djhoese removed the blocked Waiting on an external action (eg release of other package) label Apr 18, 2021
@djhoese
Copy link
Member Author

djhoese commented Apr 18, 2021

Upstream looks good. Merging.

@djhoese djhoese merged commit cb3e197 into master Apr 18, 2021
@djhoese djhoese deleted the ci-nightly-url branch April 18, 2021 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mraspaud mraspaud mraspaud approved these changes

Assignees

@djhoese djhoese

Labels

bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@djhoese @mraspaud