Deleting samples from sample information - only removes those visible on screen

[justinshaffer]

Hello,

Background: I accidentally added samples to my sample information file that I am trying to remove (ca. hundreds of samples) in order to keep things clean.

Problem: After selecting the few hundred samples to delete, and clicking 'Delete selected' - I notice that only those samples that are visible on the screen (ca. 50) are removed.

Potential solution: Increase functionality to delete all samples that are selected, rather than those only displayed on the screen.

Study: https://qiita.ucsd.edu/study/description/13046#

Thanks in advance for any solutions!

[ackermag]

There is already an issue for this in Git. It is very annoying.

…

On Thu, Mar 12, 2020 at 10:43 AM Justin Shaffer ***@***.***> wrote: Hello, Background: I accidentally added samples to my sample information file that I am trying to remove (ca. hundreds of samples) in order to keep things clean. Problem: After selecting the few hundred samples to delete, and clicking 'Delete selected' - I notice that only those samples that are visible on the screen (ca. 50) are removed. Potential solution: Increase functionality to delete all samples that are selected, rather than those only displayed on the screen. Study: https://qiita.ucsd.edu/study/description/13046# Thanks in advance for any solutions! — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#2979>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAPL3AFSPXEJ2CVWLVN2NALRHENK3ANCNFSM4LGR2Z3Q> .

-- Gail Ackermann Knight Lab UCSD glackermann@ucsd.edu <ackermag@ucsd.edu>

[justinshaffer]

Whoops! Sorry for doubling up - I did a search on 'deleting samples' and nothing relevant popped up. Please let me know if I should close my issue. Justin On Thu, Mar 12, 2020 at 10:54 AM Gail Ackermann <notifications@github.com> wrote:

…

There is already an issue for this in Git. It is very annoying. On Thu, Mar 12, 2020 at 10:43 AM Justin Shaffer ***@***.***> wrote: > Hello, > > Background: I accidentally added samples to my sample information file > that I am trying to remove (ca. hundreds of samples) in order to keep > things clean. > > Problem: After selecting the few hundred samples to delete, and clicking > 'Delete selected' - I notice that only those samples that are visible on > the screen (ca. 50) are removed. > > Potential solution: Increase functionality to delete all samples that are > selected, rather than those only displayed on the screen. > > Study: https://qiita.ucsd.edu/study/description/13046# > > Thanks in advance for any solutions! > > — > You are receiving this because you are subscribed to this thread. > Reply to this email directly, view it on GitHub > <#2979>, or unsubscribe > < https://github.com/notifications/unsubscribe-auth/AAPL3AFSPXEJ2CVWLVN2NALRHENK3ANCNFSM4LGR2Z3Q > > . > -- Gail Ackermann Knight Lab UCSD ***@***.*** ***@***.***> — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#2979 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADSDCGFMA5KVPW3QG2VZNNTRHEOVFANCNFSM4LGR2Z3Q> .

-- Justin Shaffer, PhD IRACDA Postdoctoral Fellow Rob Knight Group Department of Pediatrics, School of Medicine University of California, San Diego justinshafferbio.wordpress.com

[antgonza]

I couldn't easily find the issue, I think cause it was "solved". The initial report was that when you clicked on the [ ] not all samples will be selected, which was fixed. However, the actual delete button is not using that improved code ... will issue a PR soon.

[sjanssen2]

I am still experiencing this issue now, could it be that latest changes are not live yet?

[antgonza]

That is correct, it will be deployed on Monday ...