redbiom nice display of 504 #2311
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After doing some more tests with qiita/redbiom, I realized that if you retrieve a lot of results, the server will send a 504 (timeout) and this wasn't being caught by JS. Obviously, this is not a solution but the solution is something that might take some discussion of how to better implement + implementation time. So for the time being this PR adds a "nice" error message.
If timeout:

if something else,

Additionally, decided to improve the show_loading by adding a flag to show some extra text: "This task might take a long time (up to 5 minutes), please do not close this page.". This feature is currently only being used by redbiom but this might be useful for others in the future. Note that 5 min is just a number based on what I was seeing in my tests.