Skip to content

Conversation

antgonza
Copy link
Member

After doing some more tests with qiita/redbiom, I realized that if you retrieve a lot of results, the server will send a 504 (timeout) and this wasn't being caught by JS. Obviously, this is not a solution but the solution is something that might take some discussion of how to better implement + implementation time. So for the time being this PR adds a "nice" error message.

If timeout:
504

if something else,
500

Additionally, decided to improve the show_loading by adding a flag to show some extra text: "This task might take a long time (up to 5 minutes), please do not close this page.". This feature is currently only being used by redbiom but this might be useful for others in the future. Note that 5 min is just a number based on what I was seeing in my tests.

@antgonza antgonza changed the title nice display of 504 redbiom nice display of 504 Sep 26, 2017
@codecov-io
Copy link

codecov-io commented Sep 26, 2017

Codecov Report

Merging #2311 into release-candidate will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                @@
##           release-candidate   #2311   +/-   ##
=================================================
  Coverage               93.8%   93.8%           
=================================================
  Files                    163     163           
  Lines                  18581   18581           
=================================================
  Hits                   17430   17430           
  Misses                  1151    1151

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b14656...210c0c5. Read the comment docs.

@ElDeveloper ElDeveloper merged commit 96a174f into qiita-spots:release-candidate Sep 26, 2017
@antgonza antgonza deleted the redbiom-504 branch February 17, 2018 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants