Testing updates #61
Merged
Testing updates #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antgonza
requested changes
May 24, 2023
Tests in BaseStepTests were being inherited by child BaseStepTests and run two more times (one for Amplicon and one for Metagenomic). Partitioning out general tests into a new child class allows all children to inherit configuration, but not inherit tests.
antgonza
reviewed
May 25, 2023
Migrated pipeline calls into a single function to preserve their sequence, offer potential alternatives, and include a debug option to not update Qiita.
antgonza
added a commit
that referenced
this pull request
May 26, 2023
* DRY refactoring (#60) * WIP DRY refactoring Goal is to refactor code so that there is minimal duplication, easily extensible to enable metatranscriptomics and future Assay types, and breakout all of the functionality from the main plugin function so they can be tested properly. * Forgot to add new Step files to DRY refactor. Some Additional modifications added. * Laying out new test classes * Added support for base Step tests * Ensure output_dir is created * bugfix * Temporarily set mg-scripts dependency to development version * .gitignore fix * First test w/pseudo job-submission added. * CI Fixes * Fix for CI * debug CI. test works as intended locally * debugging CI * ci debug * ci debug * ci debug * Added test for base QCJob * Added MetagenomicStep tests * Updated testing infrastructure * Added AmpliconStep tests * flake8 * setup now points to merged mg-scripts. * Updated code to create fake files in a searchable path. * Bugfix * flake8 * Easy updates based on feedback * Removed configuration.json Removed configuration.json. Additional updates based on testing and feedback. * Merged klp_util.py into Step and klp.py based on feedback * Removed test_klp_util.py * Updates based on testing * Updates based on feedback * Changes based on feedback * Add new file * Changes based on feedback * bugfix * Testing updates (#61) * Updates based on testing on qiita-rc * Updates based on feedback * Updates based on feedback * Removed sn_tid_map_by_project as a constructor parameter for Step() * flake8 * Updates based on feedback * Added test for get_special_map() * Added test_get_tube_ids_from_qiita() * Split BaseStepTests into two halves. Tests in BaseStepTests were being inherited by child BaseStepTests and run two more times (one for Amplicon and one for Metagenomic). Partitioning out general tests into a new child class allows all children to inherit configuration, but not inherit tests. * Updates based on feedback * Updates based on feedback * Migrated pipeline calls into a single function Migrated pipeline calls into a single function to preserve their sequence, offer potential alternatives, and include a debug option to not update Qiita. * Adding coveralls to project * bugfix * test coveralls * Updating coveralls * Testing codecov integration * testing codecov * Testing codecov --------- Co-authored-by: Charles Cowart <[email protected]>
charles-cowart
added a commit
that referenced
this pull request
Jun 6, 2023
This code was originally reviewed and approved as part of the following PRs: #60 #61 Code refactored to be more extensible to new Assay types. Also, monolithic unit-tests that required testing on Qiita-RC were removed. New unittests are more numerous and test smaller self-contained functionality. Qiita is no longer needed for testing; FakeQiita class is now used to emulate canned Qiita API queries. Job submission and SLURM responses are also emulated w/fake binaries.
charles-cowart
added a commit
that referenced
this pull request
Jun 7, 2023
This code was originally reviewed and approved as part of the following PRs: #60 #61 Code refactored to be more extensible to new Assay types. Also, monolithic unit-tests that required testing on Qiita-RC were removed. New unittests are more numerous and test smaller self-contained functionality. Qiita is no longer needed for testing; FakeQiita class is now used to emulate canned Qiita API queries. Job submission and SLURM responses are also emulated w/fake binaries.
charles-cowart
added a commit
that referenced
this pull request
Jun 7, 2023
This code was originally reviewed and approved as part of the following PRs: #60 #61 Code refactored to be more extensible to new Assay types. Also, monolithic unit-tests that required testing on Qiita-RC were removed. New unittests are more numerous and test smaller self-contained functionality. Qiita is no longer needed for testing; FakeQiita class is now used to emulate canned Qiita API queries. Job submission and SLURM responses are also emulated w/fake binaries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should require qiita-spots/mg-scripts#98 to be approved and merged beforehand to pass CI.