Skip to content

Conversation

tmoida
Copy link

@tmoida tmoida commented Aug 8, 2025

  • Updated AudioRecord and AudioPlayback scripts to support both PulseAudio and PipeWire
  • Added AUDIO_BACKEND variable for backend selection
  • Updated README files with usage instructions for both backends
  • Modified LAVA test plan to run tests with both PulseAudio and PipeWire

Copy link
Contributor

@smuppand smuppand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tmoida Could you please squash the commits into a single one?

@tmoida
Copy link
Author

tmoida commented Aug 11, 2025

Hi @smuppand ,
I have squashed the commits into a single one as requested. Kindly review it and let me know if any further changes are needed.

Copy link
Contributor

@smuppand smuppand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few chnages needed like pre-scan dmesg (use common helpers) -> Run playback (possibly loop) -> post-scan dmesg fir any potential audio-related dmesg messages detected.

better to add a daemon check which prevents false failures when the server isn't running

loops + timeout - Lets you simulate longer playback without hanging CI.

@tmoida
Copy link
Author

tmoida commented Aug 14, 2025

Hi @smuppand,
I've updated the Audio test scripts and documentation as per the feedback. Key improvements include:

- Added daemon checks for both PulseAudio and PipeWire backends
- Replaced eval with safer command execution using sh -c
- Introduced support for environment variables like PLAYBACK_VOLUME, PLAYBACK_TIMEOUT, PLAYBACK_LOOPS, RECORD_TIMEOUT, and RECORD_LOOPS
- Implemented pre/post dmesg scanning using get_kernel_log and scan_dmesg_errors
- Updated both README files to reflect the new features and usage instructions

Please let me know if there is anything else that needs to be addressed.

@smuppand
Copy link
Contributor

@tmoida , please squash your commits.

@tmoida
Copy link
Author

tmoida commented Aug 20, 2025

Hi @smuppand,

I've squashed the commits and fixed the Shell Check warning by using the loop variable. Please let me know if there is anything else that needs to be addressed.

Also. I have validated these scripts on Yocto builds, and they work fine. However, on Mainline (Nightly sanity) builds, they are being skipped due to a missing timeout binary. I wanted to check: will the timeout binary be included in future builds, or should I update the script to avoid using it?

@smuppand
Copy link
Contributor

Hi @smuppand,

I've squashed the commits and fixed the Shell Check warning by using the loop variable. Please let me know if there is anything else that needs to be addressed.

Also. I have validated these scripts on Yocto builds, and they work fine. However, on Mainline (Nightly sanity) builds, they are being skipped due to a missing timeout binary. I wanted to check: will the timeout binary be included in future builds, or should I update the script to avoid using it?

You can use the library function run_with_timeout() if the build does not include the timeout utility.

@tmoida
Copy link
Author

tmoida commented Aug 22, 2025

Hi @smuppand,

Thanks for the suggestions!

I've updated the loop logic to handle early exits cleanly and added clearer return handling to distinguish between success and timeout cases. Also, I've replaced timeout with run_with_timeout() as a fallback to ensure compatibility on builds where the timeout binary is missing.

Please let me know if there is anything else that needs to be addressed.

@smuppand
Copy link
Contributor

@tmoida Please update the https://github.com/qualcomm-linux/qcom-linux-testkit/blob/main/Runner/plans/meta-ar-ci-premerge.yaml to include the changes that involve launching or adding any tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants