Implement ControlledGate #430
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add extensions parameter to PotentialImplementation to allow recursive casting - Fix ParameterizableGate not being exported
|
The build failure on travis is some kind of mypy bug. Opened #431 to investigate. |
kevinsung
reviewed
May 29, 2018
| gate_features.ParameterizableGate, | ||
| gate_features.ReversibleGate, | ||
| gate_features.TextDiagrammableGate, | ||
| ) |
There was a problem hiding this comment.
Why are these particular subclasses in this list?
There was a problem hiding this comment.
Hmm I think I see ... these are the ones that you implemented methods for.
kevinsung
reviewed
May 29, 2018
| if desired_type in POTENTIALLY_EXPOSED_SUB_TYPES: | ||
| cast_sub_gate = ext.try_cast(self.sub_gate, desired_type) | ||
| if cast_sub_gate is None: | ||
| return None |
There was a problem hiding this comment.
Why not raise a TypeError, as you do in _cast_sub_gate?
There was a problem hiding this comment.
Because this is a try_cast method, not a cast method.
This method is inherited from PotentialImplementation and so must satisfy that contract as opposed to one that may be more convenient to this specific class.
There was a problem hiding this comment.
Okay, I guess this is just following the docstring of try_cast_to.
kevinsung
approved these changes
May 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #389
Fixes #431