feat: add config option for informerListLimit #669
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@metacosm do I understand correctly that the error: is because of the Optional, is there an other way to fix this, than rename the property in this case? |
|
LGTM but will keep this open until operator-framework/java-operator-sdk#2004 is available in a JOSDK release so that we add the associated changes here as well. |
|
@metacosm kk, will prepare those changes |
Quarkus recordable constructors require a getter for each named parameter, with the appropriate type. In this case, the parameter was named informerListLimit and of type Long while the corresponding getter was returning Optional<Long>, hence the mismatch.
metacosm
force-pushed
the
informer-paging
branch
from
1a3471c to
2babb8c
Compare
metacosm
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.