-
Notifications
You must be signed in to change notification settings - Fork 383
Brand extension #13193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Brand extension #13193
Conversation
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
Do we test commands like Includes tests for brand extension consumers:
HTML format does not yet support file-based fonts #12501; we'll have to test them with brand extension when we implement them. I couldn't get revealjs to render in this project so no test for that one
@cscheid, I think this is ready to merge, but please review bc31efd and the note above about grandparent directory. |
e49a509
to
9c1481e
Compare
Yeah, the change I made to Let's review tomorrow! |
5118901
to
6b4f7f6
Compare
6b4f7f6
to
135b59c
Compare
I will submit a separate PR extending metadata extensions to single-file projects, which we can consider in the future. For now, we need a |
Last thing I'll mention here: post-processing of It was looking for paths starting with I can't find any previous issues referencing this, but logo paths were not resolved without 135b59c, and it's too risky to change Windows to use forward slashes for HTML output so late in the release. |
Fixes #12559
This extension builds on the metadata extension, providing a sample brand.yml
To do this, we need to look at the project's
project.brand
and not justbrand
. Also includes @cscheid's fix merging the extension metadata during construction of the project context.Posting as draft:
_quarto.yml
in order for the example in the extension to work — shouldn't the extension work without a project?