Skip to content

Conversation

cderv
Copy link

@cderv cderv commented Oct 7, 2025

And use some common actions that handle multiple OSes setup

cderv added 4 commits October 7, 2025 20:04
And use some common actions that handle multiple OSes setup
The fuzz crate uses #![no_main] which causes linker errors on Windows
when built with `cargo build`. While Linux/Mac linkers seems to be permissive and allow this, the resulting binaries are probably non-functional. It seems fuzz targets should only be built with `cargo fuzz` as the directory README explain
@cderv
Copy link
Author

cderv commented Oct 7, 2025

So now this run test on windows.

I need to make an adjustment to the cargo build because of linker not compatible with the fuzz target.

And this confirm some of the tests are not passing. Maybe they should be fixed before merging this

@cderv
Copy link
Author

cderv commented Oct 7, 2025

I wonder if this could be usual multi os project and related to line ending difference. Especially as some of the failing test are snapshot test.
But if Rust handles normalization at reading it should not be a problem 🤔

And also to check the path separator / vs \\ (or escaped version of \) 😓

@cderv
Copy link
Author

cderv commented Oct 10, 2025

  • do the normalization where it needs to be only
  • Look at how to avoid build fuzz target in Cargo.toml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant