Skip to content

Fix roundtripping of raw latex blocks #559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 2, 2024
Merged

Fix roundtripping of raw latex blocks #559

merged 2 commits into from
Oct 2, 2024

Conversation

gtritchie
Copy link
Collaborator

Fixes #558

Update custom pandoc writer to preserve raw latex blocks ({=latex}) when using Visual Editor.

This was due to a Pandoc 3.2+ change that stripped these blocks when we converted from the AST to markdown.

NOTE, we still don't preserve {=tex} fenced blocks, but that was true before the pandoc change. I tried updating the script to also preserve {=tex} but it didn't work, so the root cause is elsewhere.

@gtritchie gtritchie requested review from jjallaire and cscheid October 2, 2024 19:34
@cscheid
Copy link
Contributor

cscheid commented Oct 2, 2024

Thanks. This looks good.

With that said, I'm starting to wish we had a test suite here.

Copy link
Contributor

@cscheid cscheid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@gtritchie gtritchie merged commit 20fb64c into main Oct 2, 2024
@gtritchie gtritchie deleted the fix-raw-tex-latex branch October 2, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Visual Editor loses raw latex code blocks
3 participants