Skip to content

Use new positron.reopenWith command to switch between visual/source editing #684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 21, 2025

Conversation

juliasilge
Copy link
Collaborator

@juliasilge juliasilge commented Mar 20, 2025

Related to posit-dev/positron#6698 where we added this new command, specifically to be used in Quarto

Also related to intermittent bad behavior we see reported such as in #627

We've wanted to do this for a long time, because this new approach is much safer (more like the built-in ReOpenInTextEditorAction that VS Code itself uses) than trying to do all that switching from the extension. See more details in posit-dev/positron#6230.

Unfortunately, we can't remove the other code path, because this command is one we newly exposed to extensions in Positron only.

@juliasilge
Copy link
Collaborator Author

This also improves the behavior when you have multiple editors open; with the other code path, you sometimes get weird closing of background editors.

@juliasilge
Copy link
Collaborator Author

It's worth having someone try out the .vsix generated here in both VS Code and Positron; I see good behavior in both, although still some of the (same, expected) weirdness in VS Code unfortunately.

@juliasilge juliasilge requested a review from isabelizimm March 20, 2025 22:33
Copy link
Collaborator

@isabelizimm isabelizimm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the Positron experience is really nice! No more jittery editors 🎉

@juliasilge juliasilge merged commit 0fc0f41 into main Mar 21, 2025
1 check passed
@cscheid
Copy link
Contributor

cscheid commented Mar 21, 2025

Long-awaited, this is really great!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants