Skip to content

Display command titles on editor action bar in Positron #692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from

Conversation

juliasilge
Copy link
Collaborator

Related to posit-dev/positron#7191
Related to posit-dev/positron#6440

I'll leave this in draft until we get some of the other controls set up as well. In VS Code, this all falls back to the basic behavior (no titles).

@juliasilge
Copy link
Collaborator Author

The work in 306602e is to explore options for using posit-dev/positron#7237, but as of this writing it is not currently a great fit as outlined in posit-dev/positron#7237 (review).

@softwarenerd
Copy link
Contributor

The work in 306602e is to explore options for using posit-dev/positron#7237, but as of this writing it is not currently a great fit as outlined in posit-dev/positron#7237 (review).

I've also commented here: posit-dev/positron#7237 (comment)

@juliasilge
Copy link
Collaborator Author

In b6fd6f5, I just tried out an approach to:

  • initialize the context key from the configuration setting
  • store the clicked state in workspace storage

This may be a good way to go, but I am finding that I can't get the checkbox to respond to the context key. I have this to specify the checkbox:

      {
        "command": "quarto.toggleRenderOnSave",
        "title": "Render on Save",
        "enablement": "isPositron",
        "actionBarOptions": {
            "controlType": "checkbox",
            "checked": "quarto.renderOnSave == true"
        }
      },

But then it seems to me like the checkbox doesn't respond to the context key:

render-on-save

@juliasilge
Copy link
Collaborator Author

Closed by #698

@juliasilge juliasilge closed this Apr 19, 2025
@juliasilge juliasilge deleted the feature/titles-on-action-bar branch April 19, 2025 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants