feat: PackageCollector
#20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test ReportReport generated on 01-Dec-2022 at 12:52:53 by pytest-md Summary25 tests ran in 4.78 seconds
Coverage Report
|
janbritz
force-pushed
the
feature/collector
branch
from
8626c5c to
0efae59
Compare
The `PackgeCollector` can currently handle a local directory and packages from a LMS.
MartinGauk
force-pushed
the
feature/collector
branch
from
0efae59 to
52372d8
Compare
MartinGauk
requested changes
Nov 17, 2022
MHajoha
requested changes
Nov 21, 2022
Comment on lines
+22
to
+24
| async def _get_manifest(self, path: Path) -> Manifest: | ||
| async with self._worker_pool.get_worker(path, 0, None) as worker: | ||
| return await worker.get_manifest() |
There was a problem hiding this comment.
Ist es wirklich nötig, einen Worker zu starten, um das Manifest zu lesen? Für das Lesen des Manifests muss doch kein Code des Pakets ausgeführt werden, sondern nur eine JSON-Datei daraus gelesen werden.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Der
PackageCollectorinitialisiert und managt intern folgende Sub-Kollektoren, welche das Manifest von Paketen extrahieren und eine zugehörigePackage-Klasse erstellen:LocalCollector:LMSCollector:.get(hash)beimPackageCollectorabgerufen werdenRepoCollector:Zusätzlich zu diesen Sub-Kollektoren wird ein
Indexerinitialisiert. Diese Klasse speichert allePackages (jeglichen Ursprungs) intern ab und ermöglicht es, bei wiederholten Abfragen des selben Pakets direkt das gespeichertePackagezurückzugeben. Dadurch muss bei bereits indexierten Paketen nicht erneut das Manifest extrahiert werden. Nach einer vordefinierten Zeitspanne ruft derIndexerdie.get_packages()-Methode desLocalCollectors und derRepoCollectoren auf, um den Index zu aktualisieren.