Skip to content

[Junie]: feat(build-helper): add plugin for conditional code generation #1023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jetbrains-junie[bot]
Copy link
Contributor

📌 Hey! This PR was made for you with Junie, the coding agent by JetBrains Early Access Preview

It's still learning, developing, and might make mistakes. Please make sure you review the changes before you accept them.
We’d love your feedback — join our Discord to share bugs, ideas: here.

📊 Junie Summary

The build-helper:uptodate-property plugin was added to prevent rebuilding message classes unless the FIX spec XML files change, and Maven profiles were created for each FIX version to conditionally include code generation executions. The implementation was completed and submitted.

 The `build-helper:uptodate-property` plugin was added to prevent rebuilding message classes unless the FIX spec XML files change, and Maven profiles were created for each FIX version to conditionally include code generation executions. The implementation was completed and submitted.
@chrjohn
Copy link
Member

chrjohn commented Jul 25, 2025

@jetbrains-junie, well, tests are failing and the solution looks quite complex to me. Let me try again, I think I was not specific enough in my initial issue.

Please use the build-helper:uptodate-property the following way: use the FIX spec XML file to determine the base timestamp and only re-generate the classes if the JAR file in the specific quickfixj-messages-fix*/target folder either does not exist or is older than the XML spec file.

That should be good enough for our use case.

Copy link
Contributor Author

Hey, it’s Junie by JetBrains! I started processing your request 🚀

Copy link
Contributor Author

❌ Application Setup Failed

We couldn't start the application due to an environment issue during setup.

Error Details:


Dev container up failed: Command failed: /bin/sh -c ./mvnw install -B -V -Dmaven.javadoc.skip=true -DskipTests -PskipBundlePlugin,minimal-fix-latest (exit code: undefined)
Command failed: /bin/sh -c ./mvnw install -B -V -Dmaven.javadoc.skip=true -DskipTests -PskipBundlePlugin,minimal-fix-latest

More information:

@chrjohn
Copy link
Member

chrjohn commented Jul 25, 2025

@jetbrains-junie please try again

Copy link
Contributor Author

Hey, it’s Junie by JetBrains! I started processing your request 🚀

Copy link
Contributor Author

❌ Application Setup Failed

We couldn't start the application due to an environment issue during setup.

Error Details:


Dev container up failed: Command failed: /bin/sh -c ./mvnw install -B -V -Dmaven.javadoc.skip=true -DskipTests -PskipBundlePlugin,minimal-fix-latest (exit code: undefined)
Command failed: /bin/sh -c ./mvnw install -B -V -Dmaven.javadoc.skip=true -DskipTests -PskipBundlePlugin,minimal-fix-latest

More information:

@chrjohn chrjohn closed this Jul 25, 2025
@chrjohn chrjohn reopened this Jul 25, 2025
@chrjohn
Copy link
Member

chrjohn commented Jul 25, 2025

@jetbrains-junie please try again

Copy link
Contributor Author

Hey, it’s Junie by JetBrains! I started processing your request 🚀

Copy link
Contributor Author

❌ Application Setup Failed

We couldn't start the application due to an environment issue during setup.

Error Details:


Dev container up failed: Command failed: /bin/sh -c ./mvnw install -B -V -Dmaven.javadoc.skip=true -DskipTests -PskipBundlePlugin,minimal-fix-latest (exit code: undefined)
Command failed: /bin/sh -c ./mvnw install -B -V -Dmaven.javadoc.skip=true -DskipTests -PskipBundlePlugin,minimal-fix-latest

More information:

@chrjohn chrjohn closed this Jul 25, 2025
@chrjohn chrjohn deleted the jetbrains-junie/issue-1022-run-4a8326f7-3363-4bd9-9c31-ed3f21f7bdc5 branch July 25, 2025 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Message classes should not be built if spec did not change
1 participant