Only check for ApplVerID on Logon and application messages #261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrjohn
changed the title
chrjohn
reviewed
May 4, 2020
| quickfix.Message message; | ||
| DataDictionary payloadDictionary; | ||
| final quickfix.Message message; | ||
| final DataDictionary payloadDictionary; |
There was a problem hiding this comment.
Added somefinal here to make it look similar to the surrounding code.
chrjohn
reviewed
May 4, 2020
| final boolean doValidation = payloadDictionary != null; | ||
| final boolean validateChecksum = session.isValidateChecksum(); | ||
|
|
||
| message = messageFactory.create(beginString, applVerID, msgType); |
There was a problem hiding this comment.
Pulled this out of the if-else-block since the assignment was the same.
|
Hi @philipwhiuk, I have added one commit. If it is OK with you I am going to merge this. |
chrjohn
changed the title
jli8000
pushed a commit
to jli8000/quickfixj
that referenced
this pull request
Sep 22, 2020
* Only check for AppVerID on logon and app messages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #260