Skip to content

Add reconnectThreads functionality to ThreadedSocketInitiator. #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 28, 2020
Merged

Add reconnectThreads functionality to ThreadedSocketInitiator. #320

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion quickfixj-core/src/main/java/quickfix/ThreadedSocketInitiator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ public class ThreadedSocketInitiator extends AbstractSocketInitiator {

private ThreadedSocketInitiator(Builder builder) throws ConfigError {
super(builder.application, builder.messageStoreFactory, builder.settings,
builder.logFactory, builder.messageFactory);
builder.logFactory, builder.messageFactory, builder.numReconnectThreads);

if (builder.queueCapacity >= 0) {
eventHandlingStrategy
Expand All @@ -47,10 +47,18 @@ public static Builder newBuilder() {
}

public static final class Builder extends AbstractSessionConnectorBuilder<Builder, ThreadedSocketInitiator> {

int numReconnectThreads = 3;

private Builder() {
super(Builder.class);
}

public Builder withReconnectThreads(int numReconnectThreads) throws ConfigError {
this.numReconnectThreads = numReconnectThreads;
return this;
}

@Override
protected ThreadedSocketInitiator doBuild() throws ConfigError {
return new ThreadedSocketInitiator(this);
Expand Down
2 changes: 1 addition & 1 deletion quickfixj-core/src/main/java/quickfix/mina/acceptor/AbstractSocketAcceptor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ private void createSessions(SessionSettings settings) throws ConfigError, FieldC
}
} catch (Throwable t) {
if (continueInitOnError) {
log.error("error during session initialization, continuing...", t);
log.error("error during session initialization for {}, continuing...", sessionID, t);
} else {
throw t instanceof ConfigError ? (ConfigError) t : new ConfigError(
"error during session initialization", t);
Expand Down
2 changes: 1 addition & 1 deletion quickfixj-core/src/main/java/quickfix/mina/initiator/AbstractSocketInitiator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ private void createSessions() throws ConfigError, FieldConvertError {
}
} catch (final Throwable e) {
if (continueInitOnError) {
log.error("error during session initialization, continuing...", e);
log.error("error during session initialization for {}, continuing...", sessionID, e);
} else {
throw e instanceof ConfigError ? (ConfigError) e : new ConfigError(
"error during session initialization", e);
Expand Down