QFJ-879: Small Changes: Static compiled pattern, un-sync time and slf4j update #63
Conversation
guidomedina
force-pushed
the
gm-static-pattern-unsync-time-and-slf4j-update
branch
from
f5e839f to
9ea1a1d
Compare
|
This is for QFJ-879, right? |
|
Yeah, but decided to also update few minor things in a single commit. How do I add a comment to also affect JIRA automatically? is that configured? |
chrjohn
changed the title
|
If you include the issue number in the title, JIRA has a link to the pull request on the right hand side. But AFAIK you cannot make github comments appear automatically in JIRA. Or maybe you need a special plugin for that. |
guidomedina
changed the title
guidomedina
force-pushed
the
gm-static-pattern-unsync-time-and-slf4j-update
branch
6 times, most recently
from
b134178 to
18194a6
Compare
|
Re-pushed with volatile, screw it, volatile will keep it correct and thread safe as writes are visible as soon as they are done, but TBH it is still slower than no volatile at all, though without it there is a risk of not seeing the value at all if you change the time source after some other thread have started. At least volatile won't block concurrent sessions from getting the current time. |
guidomedina
force-pushed
the
gm-static-pattern-unsync-time-and-slf4j-update
branch
from
18194a6 to
af890aa
Compare
Static final pattern variable names fixes. Slf4j updated to 1.7.18
guidomedina
force-pushed
the
gm-static-pattern-unsync-time-and-slf4j-update
branch
from
af890aa to
b5fe194
Compare
…-and-slf4j-update QFJ-879: Small Changes: Static compiled pattern, un-sync time and slf4j update
|
OK, thank you :) |
…-and-slf4j-update QFJ-879: Small Changes: Static compiled pattern, un-sync time and slf4j update Conflicts: pom.xml
…4-4 to QFJ_RELEASE_2_1_0_IG * commit '371329943fa6f3b9b1ae1ba32b0f3a912333288a': FIXAPI-1808 - Added missing tag FIXAPI-1808 - Added Strategy group to 4.4
Small changes: